Build fixes #42
Merged
Build fixes #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes a deprecation error. Just in case some user is silly enough to copy and paste that code rather than running the example properly.
Turns out cmake will report a 0 exit status even if it completely fails to build. Instead, check for stderr, and panic if any is emitted.
If the user has QTDIR or QTDIR64 env vars set (depending on target arch), use that as the path to Qt5. If these are not set, default to the homebrew install location as before.
|
@tpickett66 could you have a look at cb621e9 and sign it off, as I can't say much about MacOSX specifics? Everything else looks fine to me, thanks! ✨ |
|
I'll take a look this evening. On Fri, Apr 1, 2016, 12:46 PM florianjacob notifications@github.com wrote:
|
|
Sorry, I didn't get to this sooner; everything looks good to me. |
|
Not a problem, we all offer our precious free time here. 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some small fixes that I discovered while trying to build qmlrs. Please read each commit description and cherry-pick which changes you want. Let me know if you have any questions. Thanks!