Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return rich object + print method #36

Closed
moodymudskipper opened this issue Sep 7, 2022 · 1 comment · Fixed by #47
Closed

Return rich object + print method #36

moodymudskipper opened this issue Sep 7, 2022 · 1 comment · Fixed by #47

Comments

@moodymudskipper
Copy link
Collaborator

We want to return a list with a class "constructive"
It prints as it does now.
It contains :

  • a code item (character vector)
  • a waldo_compare item that contains the result of the comparison

The print method uses styler but users can fetch the code element and do what they want.
The waldo_compare element is used by construct_issues and to display a summary of the issues. If we have environment issues, secret issues, attribute issues, I'd like the summary just to mention it and no other detail.

construct() will update the globals$last_construct variable, which will be used by construct_issues() by default.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2023

This old thread has been automatically locked. If you think you have found something related to this, please open a new issue and link to this old issue if necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Oct 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging a pull request may close this issue.

1 participant