Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement options system #56

Merged
merged 64 commits into from
Nov 4, 2022
Merged

Conversation

moodymudskipper
Copy link
Collaborator

Closes #48

This is a big PR, with breaking changes.

  • opts_*() functions are used to tweak output
  • A template arg defaults to R option so we can setup a permanent default behaviour
  • A lot of doc
  • coverage is high

Once done we might be good to go to CRAN.

Still need to update the README and make a design choice for general options, do we want them in the template ?

This was referenced Oct 14, 2022
@moodymudskipper moodymudskipper mentioned this pull request Nov 4, 2022
# Please enter a commit message to explain why this merge is necessary,
# especially if it merges an updated upstream into a topic branch.
#
# Lines starting with '#' will be ignored, and an empty message aborts
# the commit.
@moodymudskipper moodymudskipper merged commit c5bc8f4 into main Nov 4, 2022
@moodymudskipper moodymudskipper deleted the f-48-implement-options-system branch May 11, 2023 10:52
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Alternative way of passing arguments to methods
2 participants