Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handling adding tbls with duplicate names #132

Merged
merged 15 commits into from
Nov 13, 2019
Merged

handling adding tbls with duplicate names #132

merged 15 commits into from
Nov 13, 2019

Conversation

TSchiefer
Copy link
Member

@TSchiefer TSchiefer commented Nov 8, 2019 •
edited
Loading

  • repair-argument for cdm_insert_zoomed_tbl()

this was by the way the notorious "prime time"-blocker

@TSchiefer TSchiefer requested a review from krlmlr November 8, 2019 18:54
krlmlr
krlmlr reviewed Nov 11, 2019
View reviewed changes
Copy link
Collaborator

@krlmlr krlmlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'm not sure what renaming the original table will feel like, but we'll find out.

R/add-tbl.R Show resolved Hide resolved
R/zoom.R Outdated Show resolved Hide resolved
R/add-tbl.R Outdated Show resolved Hide resolved
krlmlr
krlmlr approved these changes Nov 13, 2019
View reviewed changes
Copy link
Collaborator

@krlmlr krlmlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Can you please resolve conflicts and merge?

@TSchiefer TSchiefer merged commit 490166c into master Nov 13, 2019
@TSchiefer TSchiefer deleted the b-insert-check-unique branch November 13, 2019 10:50
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@krlmlr krlmlr krlmlr approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TSchiefer @krlmlr