Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: edits to copy and modify vignettes #1098

Merged
merged 30 commits into from Jul 6, 2022
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
ec23e1d
Docs: edits to copy and modify vignettes
IndrajeetPatil Jun 16, 2022
eabc637
Update vignettes/howto-dm-copy.Rmd
IndrajeetPatil Jun 17, 2022
7b5d39c
Update vignettes/howto-dm-rows.Rmd
IndrajeetPatil Jun 17, 2022
fb6ff5d
Merge branch 'cynkra:main' into edits_dm_copy_and_update
IndrajeetPatil Jun 17, 2022
3745dc8
revert added piping
IndrajeetPatil Jun 17, 2022
8b28a8b
created issue so the comment not needed anymore
IndrajeetPatil Jun 17, 2022
0836644
Merge branch 'cynkra:main' into edits_dm_copy_and_update
IndrajeetPatil Jun 19, 2022
3795173
mention `dm_rows_append()`
IndrajeetPatil Jun 19, 2022
d05c881
title
IndrajeetPatil Jun 19, 2022
63c119d
Merge branch 'cynkra:main' into edits_dm_copy_and_update
IndrajeetPatil Jun 19, 2022
fa926d7
scrap references to dm_rows_truncate
IndrajeetPatil Jun 19, 2022
cb8ddd0
Merge branch 'cynkra:main' into edits_dm_copy_and_update
IndrajeetPatil Jun 20, 2022
2115a4a
Merge branch 'cynkra:main' into edits_dm_copy_and_update
IndrajeetPatil Jun 21, 2022
61a7a3b
Merge branch 'cynkra:main' into edits_dm_copy_and_update
IndrajeetPatil Jun 21, 2022
21737fd
also anticipate quoted args
IndrajeetPatil Jun 22, 2022
1356f9d
Revert "also anticipate quoted args"
IndrajeetPatil Jun 22, 2022
e078883
Update vignettes/setup/setup.R
IndrajeetPatil Jun 22, 2022
e6cbe2c
support both styles for calling library
IndrajeetPatil Jun 22, 2022
8002f0e
mention argument for persisting
IndrajeetPatil Jun 22, 2022
07ab1d2
Merge branch 'cynkra:main' into edits_dm_copy_and_update
IndrajeetPatil Jun 22, 2022
ce6c781
Merge branch 'cynkra:main' into edits_dm_copy_and_update
IndrajeetPatil Jun 27, 2022
49ea232
Update vignettes/howto-dm-rows.Rmd
IndrajeetPatil Jun 27, 2022
3f53afa
Merge branch 'main' into edits_dm_copy_and_update
krlmlr Jun 28, 2022
2826379
add clarification
IndrajeetPatil Jun 28, 2022
afb14e1
Merge branch 'cynkra:main' into edits_dm_copy_and_update
IndrajeetPatil Jun 29, 2022
b3692c5
Merge branch 'cynkra:main' into edits_dm_copy_and_update
IndrajeetPatil Jul 4, 2022
a5c6b83
Merge branch 'cynkra:main' into edits_dm_copy_and_update
IndrajeetPatil Jul 4, 2022
3ee6a83
Merge branch 'cynkra:main' into edits_dm_copy_and_update
IndrajeetPatil Jul 4, 2022
889cdcb
Merge branch 'cynkra:main' into edits_dm_copy_and_update
IndrajeetPatil Jul 5, 2022
991ce20
Add method
krlmlr Jul 6, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion vignettes/howto-dm-rows.Rmd
Expand Up @@ -69,7 +69,7 @@ For more details on this see `vignette("howto-dm-theory")` and `vignette("howto-
To demonstrate the use of these table modifying methods, we will create a simple `dm` object with two tables linked by a foreign key.
Note that the `child` table has a foreign key missing (`NA`).

``````{r}
``````{r }
library(tidyverse)
library(dm)
parent <- tibble(value = c("A", "B", "C"), pk = 1:3)
Expand Down
7 changes: 2 additions & 5 deletions vignettes/setup/setup.R
Expand Up @@ -21,15 +21,12 @@ knit_print.grViz <- function(x, ...) {

# If input loads dm or tidyverse, we load it here to omit warnings
IndrajeetPatil marked this conversation as resolved.
Show resolved Hide resolved
input <- readLines(knitr::current_input())
if (rlang::has_length(grep("^library[(][?\"]dm[?\"][)]", input))) {
if (rlang::has_length(grep("^library[(]dm[)]", input))) {
IndrajeetPatil marked this conversation as resolved.
Show resolved Hide resolved
library(dm)
}
if (rlang::has_length(grep("^library[(][?\"]tidyverse[?\"][)]", input))) {
if (rlang::has_length(grep("^library[(]tidyverse[)]", input))) {
IndrajeetPatil marked this conversation as resolved.
Show resolved Hide resolved
library(tidyverse)
}
if (rlang::has_length(grep("^library[(][?\"]dplyr[?\"][)]", input))) {
library(dplyr)
}

## Link helper to enable links only on pkgdown
href <- function(title, url) {
Expand Down