feat!: copy_dm_to() uses dm_sql(). Unique keys (#1887) and autoincrement primary keys (#1725) are created on the database. Data models with cyclic references are supported on databases that allow adding constraints in ALTER TABLE statements (at this time, all except DuckDB and SQLite, #664)
#2022
Conversation
krlmlr
commented
Oct 8, 2023
•
krlmlr
commented
- Closes UKs not being set to DB #1887.
- Closes copy_dm_to() should support AI PKs #1725.
- Closes Creation of empty tables on PG DB works but throws error #847.
- Closes copy_dm_to() and cyclic foreign key constraints #664.
- Closes copy_dm_to(copy_to = ) is defunct #1385.
krlmlr
force-pushed
the
f-tinker-12
branch
2 times, most recently
from
c27b4e5
to
7c2edc6
Compare
|
@nbenn @TSchiefer @moodymudskipper: Can you please test this branch to see if it works for your projects that use dm? I'd like to send it to CRAN tomorrow. There are breaking changes to |
krlmlr
changed the title
copy_dm_to() uses dm_sql() internallydm_sql() that is a viable alternative to copy_dm_to(copy_to = ...) and also used internally by copy_dm_to(). Unique keys (#1887) and autoincrement primary keys (#1725) are created on the database. Data models with cyclic references are supported on databases that allow adding constraints in ALTER TABLE statements (at this time, all except DuckDB and SQLite, #664)
|
I just realized that this PR doesn't necessarily have to be a part of tomorrow's CRAN release. This buys us a little more time if things go sideways, which they will, one way or another. |
krlmlr
force-pushed
the
f-tinker-12
branch
4 times, most recently
from
c7d995d
to
ea27da7
Compare
krlmlr
changed the title
dm_sql() that is a viable alternative to copy_dm_to(copy_to = ...) and also used internally by copy_dm_to(). Unique keys (#1887) and autoincrement primary keys (#1725) are created on the database. Data models with cyclic references are supported on databases that allow adding constraints in ALTER TABLE statements (at this time, all except DuckDB and SQLite, #664)copy_dm_to() uses dm_sql(). Unique keys (#1887) and autoincrement primary keys (#1725) are created on the database. Data models with cyclic references are supported on databases that allow adding constraints in ALTER TABLE statements (at this time, all except DuckDB and SQLite, #664)
Current Aviator status
This pull request is currently open (not queued). How to mergeTo merge this PR, comment See the real-time status of this PR on the Aviator webapp. Use the Aviator Chrome Extension to see the status of your PR within GitHub.
|
krlmlr
force-pushed
the
f-tinker-12
branch
2 times, most recently
from
24ad46e
to
9b96fe8
Compare
aviator-app
bot
force-pushed
the
f-tinker-12
branch
from
eb4a218
to
5d6ac5b
Compare
|
This pull request failed to merge: some CI status(es) failed. Remove the Failed CI(s): codecov/project |
|
This pull request failed to merge: some CI status(es) failed. Remove the Failed CI(s): Smoke test: stock R |
Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
aviator-app
bot
force-pushed
the
f-tinker-12
branch
from
c70bfaa
to
112f6d1
Compare
|
This pull request failed to merge: some CI status(es) failed. Remove the Failed CI(s): ubuntu-22.04 (release) Postgres with covr, ubuntu-22.04 (release) MySQL with covr |
|
This pull request can't be queued because it's currently a draft. |
