Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avoid column name conflicts #47

Merged
merged 11 commits into from
Sep 10, 2019
Merged

avoid column name conflicts #47

merged 11 commits into from
Sep 10, 2019

Conversation

TSchiefer
Copy link
Member

function cdm_disambiguate_cols():

  • finds ambiguous column names
  • replaces them by paste0(table_name, separator, column_name)
  • optional message with list of renamed columns

closes #40

krlmlr
krlmlr approved these changes Sep 10, 2019
View reviewed changes
Copy link
Collaborator

@krlmlr krlmlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good. Please handle review comments in a separate PR.

R/disambiguate.R Outdated Show resolved Hide resolved
R/disambiguate.R Outdated Show resolved Hide resolved
tests/testthat/helper-src.R Show resolved Hide resolved
R/disambiguate.R Show resolved Hide resolved
@krlmlr krlmlr merged commit 49e6ecc into master Sep 10, 2019
@krlmlr krlmlr deleted the f-disambiguate branch September 10, 2019 13:40
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@krlmlr krlmlr krlmlr approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement cdm_disambiguate_cols()
2 participants
@TSchiefer @krlmlr