Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support 'Pool' objects in dm_from_src #623

Merged
merged 3 commits into from Sep 27, 2021
Merged

support 'Pool' objects in dm_from_src #623

merged 3 commits into from Sep 27, 2021

Conversation

moodymudskipper
Copy link
Collaborator

closes #599

krlmlr
krlmlr reviewed Sep 23, 2021
View reviewed changes
Copy link
Collaborator

@krlmlr krlmlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good!

tests/testthat/test-pool-support.R Outdated Show resolved Hide resolved
@krlmlr krlmlr mentioned this pull request Sep 23, 2021
Merged
krlmlr
krlmlr approved these changes Sep 27, 2021
View reviewed changes
Copy link
Collaborator

@krlmlr krlmlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@krlmlr krlmlr merged commit 72d4c1a into main Sep 27, 2021
@krlmlr krlmlr deleted the f-599-dm_from_src-pool-obj branch September 27, 2021 04:41
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@krlmlr krlmlr krlmlr approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support passage of pool object to dm_from_src
2 participants
@moodymudskipper @krlmlr