Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: add test infra and one test #9

Merged
merged 15 commits into from
Apr 14, 2023
Merged

tests: add test infra and one test #9

merged 15 commits into from
Apr 14, 2023

Conversation

maelle
Copy link
Member

@maelle maelle commented Apr 13, 2023 •
edited

No description provided.

@codecov
Copy link

codecov bot commented Apr 13, 2023 •
edited

Codecov Report

❗ No coverage uploaded for pull request base (main@c59684f). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 822b1e5 differs from pull request most recent head ff8c66b. Consider uploading reports for the commit ff8c66b to get more accurate results

@@           Coverage Diff           @@
##             main       #9   +/-   ##
=======================================
  Coverage        ?   77.50%           
=======================================
  Files           ?        3           
  Lines           ?      120           
  Branches        ?        0           
=======================================
  Hits            ?       93           
  Misses          ?       27           
  Partials        ?        0

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

krlmlr
krlmlr approved these changes Apr 13, 2023
View reviewed changes
Copy link
Contributor

@krlmlr krlmlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please skip the failing tests on non-UTF-8 platforms? Looks great otherwise!

@maelle maelle mentioned this pull request Apr 14, 2023
Closed
@maelle maelle marked this pull request as ready for review April 14, 2023 06:05
@maelle
Copy link
Member Author

maelle commented Apr 14, 2023

@krlmlr I can't merge this since I don't have write access 😉

@krlmlr krlmlr merged commit efd7037 into cynkra:main Apr 14, 2023
12 checks passed
@krlmlr
Copy link
Contributor

krlmlr commented Apr 14, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krlmlr krlmlr krlmlr approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@maelle @krlmlr