Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI/CD #39

Closed
krlmlr opened this issue Mar 22, 2021 · 10 comments · Fixed by #40
Closed

Fix CI/CD #39

krlmlr opened this issue Mar 22, 2021 · 10 comments · Fixed by #40
Milestone

Comments

@krlmlr
Copy link
Collaborator

krlmlr commented Mar 22, 2021

I changed cantons to get_cantons(), need to clean up.

@krlmlr krlmlr added this to the 0.2.0 milestone Mar 22, 2021
@TSchiefer
Copy link
Member

One problem with the check is:

❯ checking installed package size ... NOTE
    installed size is 18.8Mb
    sub-directories of 1Mb or more:
      csv  18.1Mb

Can we do anything about this? Maybe store as zip?

@krlmlr
Copy link
Collaborator Author

krlmlr commented Mar 22, 2021

Please add error_on <- "warning" to R-CMD-check.yaml for now.

@krlmlr
Copy link
Collaborator Author

krlmlr commented Mar 22, 2021

And also to ...-dev.yaml .

@TSchiefer
Copy link
Member

in R/get_merger_mapping_table.R we have this:

  if (Sys.getenv("IN_PKGDOWN") == "") {
    readr::write_csv(mutation_init, new_csv_file("debug-init", end_year))
  }

and one for debug-base.

do we still need this? (leads to an error in the R-CMD-check)

@krlmlr
Copy link
Collaborator Author

krlmlr commented Mar 22, 2021

I think we can remove it for now, also the files.

@TSchiefer
Copy link
Member

There is now one check failing, on ubuntu-18.04 (devel). No idea why the example fails in this case whereas it works fine in all other setups.
If you think we should investigate that it would be nice if you could give me a pointer how to tackle this.
If we can ignore this one failed case, I would consider this issue done.

@krlmlr
Copy link
Collaborator Author

krlmlr commented Mar 23, 2021

This looks odd. Can you please add build matrix entries for R-devel on macOS and Windows, to investigate if this occurs across platforms?

@TSchiefer
Copy link
Member

Occurs across platforms

@krlmlr
Copy link
Collaborator Author

krlmlr commented Mar 26, 2021

I can replicate locally with R devel, will take a look.

krlmlr added a commit that referenced this issue Mar 27, 2021
- Fix filter in `swc_get_mapping()` for correct results (#39).
@github-actions
Copy link

This old thread has been automatically locked. If you think you have found something related to this, please open a new issue and link to this old issue if necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants