Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

problem editing weather watchlist #72

Closed
bradanlane opened this issue Oct 6, 2015 · 6 comments
Closed

problem editing weather watchlist #72

bradanlane opened this issue Oct 6, 2015 · 6 comments

Comments

@bradanlane
Copy link
Contributor

(reported by @rgutlon)

v0.4r1 Weather Watch List Bug

Settings -> Configuration -> Watch List
Once you add entries into this field they cannot be removed. You can append entries to the list, but backspacing over existing entries has no effect (ie the change is not being written to /etc/stratux.conf).

@bradanlane
Copy link
Contributor Author

I tried this and it worked. Can you give me the exact steps (right down to keystrokes) you tried. I think the issue may be that the coee doesn't know when the user is "done" so it waits for them to hit ENTER. I can look into trapping an event if hte user touches outside the field.

At the very least, I will add help text.

@rgutlon
Copy link

rgutlon commented Oct 6, 2015

I think the issue may be that the coee doesn't know when the user is "done" so it waits for them to hit ENTER.

Just went through the process again paying attention to "returns" and you are correct.

One needs to press Enter (or GO on my iPad keyboard) in order for the change to be recorded. As the cursor neither moves position or changes visually, I may have thought GO was unnecessary and tapping outside of the field would record the input .

Thanks for double checking.

@bradanlane
Copy link
Contributor Author

I'll see if I can detect the "out of field" tap event.

Interesting your iPad keyboard says "GO" and my iPhone (iOS 9.0.2) shows "Return" in the keyboard.

@rgutlon
Copy link

rgutlon commented Oct 6, 2015

Bradan - just went through the exercise again with different results.

  • If you backspace and leave some value in the field (character, digit) it is recorded upon pressing GO (or Enter).
  • If you backspace and remove everything so the field is empty (null), this is where the change is not saved. Are you able to replicate that behavior?

@bradanlane
Copy link
Contributor Author

Yes, making it blank doesn't work. I can fix that. Understand that a blank watchlist means "watch none".

@bradanlane
Copy link
Contributor Author

I've submitted new code #73 that allows the user to submit an empty watchlist. It also tracks fiedl focus changes. IT's not perfect but it's better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants