Better porting to ST3 #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tbueno wondered what your plans are for either merging this in or doing something else to provide st3 support? |
|
@edubkendo I'll test the solution and if it works, it will be merged soon. Even if we decide to rewrite some parts later to offer better integration with ST3, we should make it compatible now. |
| @@ -1,6 +1,11 @@ | |||
| import sublime | |||
| import sublime_plugin | |||
| import thread | |||
| try: | |||
There was a problem hiding this comment.
This seems like really a Python version issue not a sublime text 2 vs. 3 issue.
Would it not be better to use something like the following to get/check the Python version?
>>> import sys
>>> sys.version_info
(2, 5, 2, 'final', 0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Saw a pull request from hayd, and tried to improve that
now it uses the Thread module and created a GuardMessageCommand to be able to put the output in the panel. The only thing missing for that is to be able to erase/clear the panel in case of text found.