Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Monerodart integration to staging #831

Closed
wants to merge 56 commits into from

Conversation

sneurlax
Copy link
Member

@sneurlax sneurlax commented Apr 9, 2024

This is based on #818: I rebased MrCyjaneK:monerodart on cypherstack:staging. #818 can be merged now.

rehrar and others added 30 commits January 18, 2024 11:40
25 words seed (didn't test yet)
updated monero.dart to support wow
25 words seed (didn't test yet)
.gitmodules Outdated
@@ -6,7 +6,7 @@
url = https://github.com/cypherstack/flutter_liblelantus.git
[submodule "crypto_plugins/monero_c"]
path = crypto_plugins/monero_c
url = https://git.mrcyjanek.net/mrcyjanek/monero_c
url = git@github.com:cypherstack/monero_c

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! The upstream source code is also available at https://github.com/mrcyjanek/monero_c

.gitmodules Outdated
@@ -6,7 +6,7 @@
url = https://github.com/cypherstack/flutter_liblelantus.git
[submodule "crypto_plugins/monero_c"]
path = crypto_plugins/monero_c
url = https://git.mrcyjanek.net/mrcyjanek/monero_c
url = git@github.com:cypherstack/monero_c

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! The upstream source code is also available at https://github.com/mrcyjanek/monero_c

@sneurlax
Copy link
Member Author

We can revert to your github repo and pin it to an audited commit hash.

I do need to change those SSH-based git@github.com URLs to typical HTTPS links, though.

TODO add to apple-docs Mac Host section
it's a WSL2 thing afaict
sudo ./build_single.sh monero x86_64-w64-mingw32 -j$(nproc)
# WSL2 needs superuser permissions related to error:
# update-alternatives: error creating symbolic link ...: Permission denied
sudo ./build_single.sh wownero x86_64-w64-mingw32 -j$(nproc)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SUDO=sudo ./build_single.sh wownero x86_64-w64-mingw32 -j$(nproc)

https://git.mrcyjanek.net/mrcyjanek/monero_c/src/commit/a032a20221579d5fb9445b370eec1b6bd4ff653b/build_single.sh#L87 (I need to change upstream for i686, but it is not used there)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I'm not sure how to integrate this comment?

@sneurlax
Copy link
Member Author

sneurlax commented Apr 25, 2024

Recreate using #838

@sneurlax sneurlax closed this Apr 25, 2024
@sneurlax sneurlax deleted the monerodart_integration branch May 4, 2024 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants