Monerodart -> testing integration #848
Conversation
Update main to v0.9.2
Update main to v1.10.1
Update to 1.10.1
Update main to v1.10.2
and update its pubspec.lock
and submodule-pinning
macos/wownero_libwallet2_api_c.dylib
Outdated
There was a problem hiding this comment.
Any reason extractNativeLibs is specifically set here?
If there is no specific reason then I suggest reverting and letting the default be chosen by the system as described in: https://developer.android.com/guide/topics/manifest/application-element
There was a problem hiding this comment.
for the .so to be extracted, the ones that are marked for deletion. I'll make it a cmake install step instead if symlinking is not desired
android/app/build.gradle
Outdated
There was a problem hiding this comment.
monero_c also depends on libc++_shared.so, and in early versions of this PR i was getting build errors because multiple packages were providing the dynamic library
crypto_plugins/flutter_libmonero
Outdated
There was a problem hiding this comment.
This requires a separate review of the changes to flutter_libmonero
Remove duplicate and join into one command
See notes on #818
Otherwise we'd have to update it. Only I use fvm on macos
otherwise we will need to maintain it and I'm the only one using fvm on macos
…re assigning a new one
|
@julian-CStack regarding .so/.dylib symlinks deletion, what is the preferred way to include them in the apk/.app on android/macos? |
| addressInfo!['accountIndex'] as int, | ||
| addressInfo['addressIndex'] as int, | ||
| addressInfo?['accountIndex'] as int? ?? 0, | ||
| addressInfo?['addressIndex'] as int? ?? 0, |
There was a problem hiding this comment.
Is it ok to default to 0 here? Or should there be some error?
There was a problem hiding this comment.
should be fine, there is no account switching feature in stack yet.
Handle in scripts. Either create symlinks, cp, or mv them to where flutter expects them to be. |
Reference #838; basically #838 +
testingbranch (which includes Bitcoin Frost and other changes)