Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 [Compose] Detaching & Reattaching of files does not work #323

Closed
ulfgebhardt opened this issue Mar 6, 2019 · 7 comments
Closed
Assignees
Labels
awaiting feedback please follow up! bug something is wrong in Cypht smtp smtp module set

Comments

@ulfgebhardt
Copy link
Contributor

ulfgebhardt commented Mar 6, 2019

馃悰 Bugreport

[Compose] Detaching & Reattaching of files does not work

Consider following Situation:

  • You want to send a File and start writing the EMail and attach the File
  • Now you notice there is a mistake in the File while writing
  • You correct the Mistake, detach the file, and try to reattach it.
  • The File does not appear, you have the start another compose

This is probl. the case since the file name has not changed.
(I did not try with a changed filename)

Version & Environment

Rev: 70a3d129f0493d7885176040b39a69d51c422921

OS: [Debian]

Steps to reproduce

  1. Attach File
  2. Detach File
  3. Reattach same File (or changed File with same name/path)
  4. ...
  5. Profit
@jasonmunro jasonmunro self-assigned this Mar 9, 2019
@jasonmunro jasonmunro added bug something is wrong in Cypht smtp smtp module set labels Mar 9, 2019
@jasonmunro
Copy link
Member

This appears to be a Javascript bug as the second attempt to attach the file never triggers a server side request. I think the problem is using a change event as part of the flow. Re-uploading the same file is not a change in state so it never triggers the actual upload. I will let you know when I have a fix.

@jasonmunro
Copy link
Member

Should be fixed in the master branch

@jasonmunro
Copy link
Member

@ulfgebhardt I believe this is fixed so I'm closing this issue. If you are still seeing issues please re-open. Thanks!

@ulfgebhardt
Copy link
Contributor Author

Hey @jasonmunro i am sorry that i did not respond in a timely manner - haven't updated cypht in quite some time. <3

@marclaporte
Copy link
Member

Related: #421

@marclaporte
Copy link
Member

@ulfgebhardt Please retest with latest code.

Thanks!

@ulfgebhardt
Copy link
Contributor Author

@marclaporte I will in time, I still work with quite the old version of cypht. Will update some day I guess <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting feedback please follow up! bug something is wrong in Cypht smtp smtp module set
Projects
No open projects
Development

No branches or pull requests

3 participants