[UX] servers page : make servers page to be responsive on mobile #1005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josaphatim
reviewed
May 14, 2024
modules/imap/output_modules.php
Outdated
|
|
||
| // IMAP Username | ||
| $res .= '<div class="form-floating">'; | ||
| $res .= '<input '.$disabled.' id="imap_user_'.$server_id.'" class="form-control credentials" type="text" name="imap_user" value="'.$this->html_safe($user_pc).'" placeholder="'.$this->trans('Username').'">'; | ||
| $res .= '<input '.$disabled.' id="imap_user_'.$server_id.'" class="form-control " type="text" name="imap_user" value="'.$this->html_safe($user_pc).'" placeholder="'.$this->trans('Username').'">'; |
There was a problem hiding this comment.
@Bienvenumoringa you should not remove class credentials as it is used in javascript. Just remove its css.
There was a problem hiding this comment.
I've already put back the credentials class so that the js works as expected. And I've removed it from the css side.
There was a problem hiding this comment.
@Bienvenumoringa this fix only for IMAP servers but not SMTP servers
There was a problem hiding this comment.
@Bienvenumoringa there is too much space between 2 servers. Can you fix ?
Bienvenumoringa
force-pushed
the
fix-respossivity
branch
2 times, most recently
from
19726a5
to
921a460
Compare
Bienvenumoringa
force-pushed
the
fix-respossivity
branch
from
921a460
to
9638e97
Compare
josaphatim
force-pushed
the
fix-respossivity
branch
from
9638e97
to
6d9398e
Compare
David-Muhasa
pushed a commit
to David-Muhasa/cypht
that referenced
this pull request
Jun 20, 2024
…pht-org#1005) * [UX] servers page : make servers page to be responsive on mobile * Arranged mobile servers to look good --------- Co-authored-by: Josaphat Imani <josaphat.imani97@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working on responsive design of servers page
?page=servers, see screenshot :