Handle Unicode in folder names #1012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It is OK to merge this as we already require mbstring extension in composer and sparingly use it mainly to convert encodings. However, if we want proper unicode support, we should do much more with the code. I see 170 different usages of substr only and there are a bunch of other string related functions that need to be converted to their multibyte counterparts - e.g. strtolower, strtoupper, strlen, strstr and probably others. @marclaporte maybe we merge this one now to fix the reported issue and release 2.0.1 and then open a PR for the rest of the places that need fixing for version 2.1.0? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pullrequest
This PR ensures compatibility with multibyte characters, including Cryllic characters in folder names
Issues
#756
How2Test