attempt to fix draft versions, missing attachments when sending email #453
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attempts to fix #421 and #436. The problem I see is with draft version numbers and the fact that new attachments are tied to a draft that is not actually saved in the session, so interactions with cypht in another browser tab could eventually destroy the attachment.
The changes implemented here are making a slight change in behavior which I think is logical. Here are they:
A side-effect of this change is the auto-saving of drafts happening on 30 seconds interval by default. We now save all draft contents even when no subject is entered (so we can keep the attachments in the drafts without subjects). I think this is behavior similar to other mail clients that won't let you quit an unsaved/unsent compose page even if there is no subject entered. We can improve here by ignoring saving of drafts that are completely empty, so opening the compose page but not doing anything should not actually save as draft.
Jason, let me know your thoughts and what else to improve here!