Added ssl/tls support for sieve #701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kroky
reviewed
Jun 23, 2023
kroky
reviewed
Jun 23, 2023
josaphatim
force-pushed
the
sieve-ssl-support
branch
3 times, most recently
from
d499d26
to
aa75de9
Compare
kroky
reviewed
Jun 26, 2023
kroky
reviewed
Jun 26, 2023
josaphatim
force-pushed
the
sieve-ssl-support
branch
3 times, most recently
from
96ebcbe
to
a997a9a
Compare
kroky
reviewed
Jul 10, 2023
josaphatim
force-pushed
the
sieve-ssl-support
branch
from
a997a9a
to
d2d99d6
Compare
kroky
reviewed
Aug 2, 2023
kroky
reviewed
Aug 2, 2023
kroky
reviewed
Aug 2, 2023
josaphatim
force-pushed
the
sieve-ssl-support
branch
2 times, most recently
from
f39e46b
to
4e93dc2
Compare
josaphatim
force-pushed
the
sieve-ssl-support
branch
2 times, most recently
from
95a4393
to
02cd863
Compare
kroky
reviewed
Aug 14, 2023
kroky
reviewed
Aug 14, 2023
|
I think you need to update Hm_Sieve_Client_Factory and also the Tiki integration which uses a port of Hm_Sieve_Client_Factory to use the new parsing method. |
josaphatim
force-pushed
the
sieve-ssl-support
branch
from
02cd863
to
cdccd59
Compare
Hello @kroky I made changes. Thanks. |
|
I don't see changes in php-sieve-manager library - how did we fix the tls parameter passing to client->connect that has no effect? |
josaphatim
force-pushed
the
sieve-ssl-support
branch
from
cdccd59
to
9ee3811
Compare
|
@kroky @josaphatim Is this suitable to backport to branch 1.4.x, or we just wait for 1.5.0? |
|
It should be fine to be backported. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding tls:// prefix to sieve configuration host will enable explicit STARTTLS
Adding ssl:// prefix to sieve configuration host will enable implicit SSL