Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows: add test ci #777

Merged
merged 1 commit into from
Oct 5, 2023
Merged

workflows: add test ci #777

merged 1 commit into from
Oct 5, 2023

Conversation

wangxiaoerYah
Copy link
Contributor

Pullrequest

Issues

  • None

Checklist

  • None

How2Test

  • None

Todo

  • None

@wangxiaoerYah
Copy link
Contributor Author

Wrote unit tests for the project to run on github action, preview

@wangxiaoerYah
Copy link
Contributor Author

@marclaporte On php8.2, which defaults phpunit version to 10.3, I got the error.preview

@wangxiaoerYah
Copy link
Contributor Author

@marclaporte I'm new to php and I'd like to know what's going on?

@wangxiaoerYah
Copy link
Contributor Author

But on php7.4 it works fine.

@wangxiaoerYah
Copy link
Contributor Author

After completing the selenium test, I think I can try to compile the image. Before that, I hope you can open a dev branch to correspond to the night version.

@wangxiaoerYah wangxiaoerYah changed the title workflows: add test workflows: add test ci Sep 30, 2023
@wangxiaoerYah
Copy link
Contributor Author

Merge as soon as possible, I'm in a hurry🥹🥹

@marclaporte
Copy link
Member

Thank you @wangxiaoerYah !

@josaphatim will look into it.

@kroky
Copy link
Member

kroky commented Oct 5, 2023

Looks good to me. Thanks @wangxiaoerYah!

PHP 8.2 and newer phpunit versions need some fixes in the tests, we will do that later when we prepare next release of Cypht. For now, maybe you can keep the ci pipeline with php 8.2 commented?

We don't build an image of Cypht, it is released by tagging specific version after we plan a release. If you need to reference a nighly version, just use latest master or a specific commit in the git history of master if you target specific code.

@kroky kroky merged commit c240489 into cypht-org:master Oct 5, 2023
@kroky
Copy link
Member

kroky commented Oct 5, 2023

Btw, one nice addition here if you happen to work again on the selenium tests integration is copying the hm3.sample.ini to .github/tests and modifying the variables you want (I think only the db connection variables were modified from the default ones). This way, we will safeguard against future changes of hm3.sample.ini.

@marclaporte
Copy link
Member

marclaporte commented Oct 5, 2023

Thank you @wangxiaoerYah and @kroky !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants