-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
workflows: add test ci #777
Conversation
Wrote unit tests for the project to run on github action, preview |
@marclaporte On php8.2, which defaults phpunit version to 10.3, I got the error.preview |
@marclaporte I'm new to php and I'd like to know what's going on? |
But on php7.4 it works fine. |
After completing the selenium test, I think I can try to compile the image. Before that, I hope you can open a dev branch to correspond to the night version. |
Merge as soon as possible, I'm in a hurry🥹🥹 |
Thank you @wangxiaoerYah ! @josaphatim will look into it. |
Looks good to me. Thanks @wangxiaoerYah! PHP 8.2 and newer phpunit versions need some fixes in the tests, we will do that later when we prepare next release of Cypht. For now, maybe you can keep the ci pipeline with php 8.2 commented? We don't build an image of Cypht, it is released by tagging specific version after we plan a release. If you need to reference a nighly version, just use latest master or a specific commit in the git history of master if you target specific code. |
Btw, one nice addition here if you happen to work again on the selenium tests integration is copying the hm3.sample.ini to .github/tests and modifying the variables you want (I think only the db connection variables were modified from the default ones). This way, we will safeguard against future changes of hm3.sample.ini. |
Thank you @wangxiaoerYah and @kroky !! |
Pullrequest
Issues
Checklist
How2Test
Todo