Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Plain text showing as attachment #815

Merged
merged 1 commit into from
Dec 14, 2023
Merged

Fixed Plain text showing as attachment #815

merged 1 commit into from
Dec 14, 2023

Conversation

josaphatim
Copy link
Member

@josaphatim josaphatim commented Oct 30, 2023 •
edited

Fixes #794

Using php explode function on empty string creates an array with 1 key. Which makes the attachment array to have at least one key.

@marclaporte marclaporte mentioned this pull request Nov 4, 2023
Closed
ulfgebhardt
ulfgebhardt approved these changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@ulfgebhardt ulfgebhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this branch I get the old view when writing new EMails - old emails are still the same - I assume this is correct.

Old EMail with this branch:
image

New EMail with this branch:
image

Hence I'd say its fixed.

@marclaporte marclaporte merged commit 1b86c84 into cypht-org:master Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ulfgebhardt ulfgebhardt ulfgebhardt approved these changes

@kroky kroky Awaiting requested review from kroky

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Plain text shows as attachment
3 participants
@josaphatim @ulfgebhardt @marclaporte