Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unit tests failure related to menu icons #827

Merged
merged 1 commit into from
Dec 16, 2023

Conversation

Yannick243
Copy link
Member

Backporting (Fix unit tests failure related to menu icons) to 1.4.x as requested by josaphatim.

Cherry picked from: #818

@josaphatim
Copy link
Member

@Yannick243 seems like Hm_Test_Core_Output_Modules::test_start_junk_settings and Hm_Test_Core_Output_Modules::test_main_menu_content are still failing. Thanks.

@Yannick243
Copy link
Member Author

Thanks @josaphatim
I just realized that this pull request depends on these #824 and #826 because it contains tests related to the menus (all junk, all trash, and all drafts). However, these menus have not been backported to 1.4.x yet. Should I switch this pull request to draft until then?

@josaphatim josaphatim merged commit f61c63c into cypht-org:1.4.x Dec 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants