-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor/stmp imap server configuration #855
Merged
kroky
merged 67 commits into
cypht-org:master
from
henochit:refactor/stmp_imap_server_configuration
Mar 22, 2024
Merged
Refactor/stmp imap server configuration #855
kroky
merged 67 commits into
cypht-org:master
from
henochit:refactor/stmp_imap_server_configuration
Mar 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…actor/stmp_imap_server_configuration
kroky
reviewed
Jan 4, 2024
kroky
reviewed
Jan 4, 2024
kroky
reviewed
Jan 4, 2024
kroky
reviewed
Jan 4, 2024
kroky
reviewed
Jan 4, 2024
kroky
reviewed
Jan 4, 2024
NUX is a module and like all other modules can be switched off. We can't depend the whole IMAP/SMTP/JMAP server management experience on a module that can be switched off. Please make sure you respect:
I think it will be best to refactor the code to move the UI, dialogs, steps and handling to the core module that can't be switched off and then reuse in nux, smtp, imap or whatever is needed. |
kroky
reviewed
Mar 12, 2024
kroky
reviewed
Mar 12, 2024
kroky
reviewed
Mar 12, 2024
kroky
reviewed
Mar 12, 2024
kroky
reviewed
Mar 12, 2024
kroky
reviewed
Mar 12, 2024
kroky
reviewed
Mar 12, 2024
kroky
reviewed
Mar 12, 2024
kroky
reviewed
Mar 12, 2024
kroky
reviewed
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal: Make it easier to set up IMAP, SMTP and connect them together (A profile with optional signature)
Context: Cypht is very flexible but quite unintuitive/complicated to set up a simple email account. Too many steps. Too many places it can go wrong and you end up with a half configured system.
A related discussion to "use login data from IMAP for SMTP"
#459
Also desired: auto-configuration via auto-detection or via an URL
Details (login required): reference
How2Test