Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/stmp imap server configuration #855

Merged

Conversation

henochit
Copy link
Member

@henochit henochit commented Jan 3, 2024

Goal: Make it easier to set up IMAP, SMTP and connect them together (A profile with optional signature)

Context: Cypht is very flexible but quite unintuitive/complicated to set up a simple email account. Too many steps. Too many places it can go wrong and you end up with a half configured system.

A related discussion to "use login data from IMAP for SMTP"
#459

Also desired: auto-configuration via auto-detection or via an URL

Details (login required): reference

How2Test

  • Configure an SMTP and IMAP server at the same time (Enable Profile creation)
  • Configure an JMAP server
  • Configure an SMTP server only
  • Configure an IMAP server only

@marclaporte marclaporte requested a review from kroky January 3, 2024 17:00
mail-debug Outdated Show resolved Hide resolved
modules/nux/modules.php Outdated Show resolved Hide resolved
modules/nux/modules.php Outdated Show resolved Hide resolved
modules/nux/modules.php Outdated Show resolved Hide resolved
modules/nux/modules.php Outdated Show resolved Hide resolved
modules/nux/modules.php Outdated Show resolved Hide resolved
@kroky
Copy link
Member

kroky commented Jan 4, 2024

NUX is a module and like all other modules can be switched off. We can't depend the whole IMAP/SMTP/JMAP server management experience on a module that can be switched off. Please make sure you respect:

  • nux being switched off but still imap/jmap/smtp server can be managed
  • jmap, smtp or imap being switched off and still nux shows the correct UI to manage servers (hiding the ones that are turned off)

I think it will be best to refactor the code to move the UI, dialogs, steps and handling to the core module that can't be switched off and then reuse in nux, smtp, imap or whatever is needed.

modules/imap/functions.php Outdated Show resolved Hide resolved
modules/imap/functions.php Outdated Show resolved Hide resolved
modules/smtp/functions.php Outdated Show resolved Hide resolved
modules/smtp/functions.php Outdated Show resolved Hide resolved
modules/smtp/functions.php Outdated Show resolved Hide resolved
modules/smtp/functions.php Outdated Show resolved Hide resolved
modules/smtp/modules.php Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants