-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] allow drag and drop of recipients with accents in the name #864
Conversation
2ae7174
to
7e82930
Compare
e4ec23a
to
22d310d
Compare
22d310d
to
a49f22b
Compare
@jacob-js thank you for the changes. Can you resolve the conflicts as we can merge? |
a49f22b
to
cd7c82f
Compare
Resolved. |
FILTER_SANITIZE_FULL_SPECIAL_CHARS should be replaced with FILTER_DEFAULT in tests as well. The idea is that we don't escape html entities in input data but do it on output in html context. |
test_filter_output filter uses FILTER_DEFAULT which makes the test to fail. FILTER_SANITIZE_FULL_SPECIAL_CHARS makes it to succeed but It does not make sense to use it. |
We need to change the tests as well - we are no longer filtering input for html special chars when storing the input. |
Pull Request
This pull request addresses the issue encountered while trying to reorder recipients between the fields
to
,cc
, andbcc
, which was not functioning. Additionally, it resolves the problem where a bubble was not being formed for a contact with an accent in the name.Issues
Checklist
How2Test
compose
to
,cc, or 'bcc
. Once the contact is found and inserted in the fieldTodo