Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] allow drag and drop of recipients with accents in the name #864

Merged
merged 2 commits into from
Feb 19, 2024

Conversation

jacob-js
Copy link
Member

@jacob-js jacob-js commented Jan 12, 2024

Pull Request

This pull request addresses the issue encountered while trying to reorder recipients between the fields to, cc, and bcc, which was not functioning. Additionally, it resolves the problem where a bubble was not being formed for a contact with an accent in the name.

Issues

Checklist

  • None

How2Test

  • Create some contacts in your interface (with or without accents in the name)
  • Navigate to compose
  • Type the contact in the field to, cc, or 'bcc. Once the contact is found and inserted in the field
  • You can drag-and-drop it to move to another field.

Todo

  • None

modules/smtp/site.js Outdated Show resolved Hide resolved
modules/contacts/modules.php Outdated Show resolved Hide resolved
lib/module.php Outdated Show resolved Hide resolved
@jacob-js jacob-js requested a review from kroky January 31, 2024 18:52
@jacob-js jacob-js force-pushed the reordering-of-recipients branch 2 times, most recently from e4ec23a to 22d310d Compare February 9, 2024 16:26
@kroky
Copy link
Member

kroky commented Feb 16, 2024

@jacob-js thank you for the changes. Can you resolve the conflicts as we can merge?

@jacob-js
Copy link
Member Author

@jacob-js thank you for the changes. Can you resolve the conflicts as we can merge?

Resolved.

@kroky kroky merged commit 3bcf6a7 into cypht-org:master Feb 19, 2024
@josaphatim
Copy link
Member

josaphatim commented Feb 20, 2024

@kroky, @jacob-js

Now this test is failing test_filter_output
Not sure but I think that FILTER_DEFAULT doesn't filter output

@kroky
Copy link
Member

kroky commented Feb 20, 2024

FILTER_SANITIZE_FULL_SPECIAL_CHARS should be replaced with FILTER_DEFAULT in tests as well. The idea is that we don't escape html entities in input data but do it on output in html context.

@josaphatim
Copy link
Member

FILTER_SANITIZE_FULL_SPECIAL_CHARS should be replaced with FILTER_DEFAULT in tests as well. The idea is that we don't escape html entities in input data but do it on output in html context.

test_filter_output filter uses FILTER_DEFAULT which makes the test to fail. FILTER_SANITIZE_FULL_SPECIAL_CHARS makes it to succeed but It does not make sense to use it.

@kroky
Copy link
Member

kroky commented Feb 22, 2024

We need to change the tests as well - we are no longer filtering input for html special chars when storing the input.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants