Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added bootstrap to carddav and ldap contacts modules #891

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

josaphatim
Copy link
Member

This MR adds bootstrap to carddav contacts and ldap contacts modules

@alvinBM
Copy link
Member

alvinBM commented Feb 11, 2024

hello @josaphatim
Thank you for noticing these modules which were forgotten during the bootstrap migration.
For the ldap_contacts module, I suggest you use the Floating label on the form fields as this form is very long, to always have the name of the field visible when it is edited or when it is filled. So you could also get rid of the .screen_reader class on the label tags

@josaphatim
Copy link
Member Author

hello @josaphatim Thank you for noticing these modules which were forgotten during the bootstrap migration. For the ldap_contacts module, I suggest you use the Floating label on the form fields as this form is very long, to always have the name of the field visible when it is edited or when it is filled. So you could also get rid of the .screen_reader class on the label tags

Thanks @alvinBM copy that !

@josaphatim
Copy link
Member Author

@alvinBM now ready.

@alvinBM
Copy link
Member

alvinBM commented Feb 12, 2024

@alvinBM now ready.

Thanks @josaphatim

@alvinBM alvinBM merged commit 77930b4 into cypht-org:master Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants