Added bootstrap files to optimized css/js files #895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josaphatim
force-pushed
the
fixed-duplicated-call-for-bootstrap-files
branch
4 times, most recently
from
5ba5f5b
to
383efad
Compare
josaphatim
force-pushed
the
fixed-duplicated-call-for-bootstrap-files
branch
from
383efad
to
a562026
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/site folder was missing bootstrap. I also fixed duplicated css files I mean bootstrap.min.css and bootstrap-icons.css were present twice in the head tag. Now accessing to /site will load all needed css/js files. This issue was impacting embedded tiki as bootstrap/bootstrap icons weren't loaded.
I also allowed css header and js files on login page to make bootstrap and js files available there. With this MR now clicking on close button in an alert message on login page will close it.