-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorganize system alert messages based on bootstrap alerts #905
Conversation
6b9bf8c
to
b41b24c
Compare
Hello @josaphatim , This PL is ready |
In my opinion, the Hm_Notices::show function to which we pass an array of messages as the first parameter should display an alert for each message instead of having a single alert for all the messages passed separated by a comma. But also the Hm_Utils::show_sys_messages method had the sole responsibility of displaying pending messages already added to the element $('.sys_messages') via elements having the .err class. I think it could keep the same role but just think about how to keep messages waiting before displaying |
b41b24c
to
1902c6d
Compare
Fixed @josaphatim, Thanks |
1902c6d
to
1ab74f5
Compare
d52a5af
to
288fdc7
Compare
288fdc7
to
ba9dd31
Compare
No description provided.