Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflows: add test-selenium #954

Merged
merged 6 commits into from
Apr 19, 2024
Merged

Workflows: add test-selenium #954

merged 6 commits into from
Apr 19, 2024

Conversation

wangxiaoerYah
Copy link
Contributor

Like I said, it didn't really run. But I think this is an idea, and I hope to submit it to the main line for everyone to refer to.

This is just a workflow, not code, has no impact on the project, and is not a broken code. It is just a Workflow.

@wangxiaoerYah
Copy link
Contributor Author

Hopefully this will provide more examples for more people.

@wangxiaoerYah
Copy link
Contributor Author

Need to merge #953, then it should work.

@josaphatim
Copy link
Member

Need to merge #953, then it should work.

Already merged.

@wangxiaoerYah
Copy link
Contributor Author

Need to merge #953, then it should work.

Already merged.

So what do you think needs to be improved?

@kroky kroky mentioned this pull request Apr 16, 2024
@kroky
Copy link
Member

kroky commented Apr 16, 2024

You added dovecot and postfix setup in order to run the selenium email sending test - awesome! I like the code but we need to make it work in order to merge. Do you have any specific issues making it work?

@wangxiaoerYah
Copy link
Contributor Author

You added dovecot and postfix setup in order to run the selenium email sending test - awesome! I like the code but we need to make it work in order to merge. Do you have any specific issues making it work?

There was a problem when I submitted because #953 was not merged.

This is my status work

@marclaporte marclaporte requested a review from kroky April 19, 2024 11:19
@kroky kroky merged commit b00b1bd into cypht-org:master Apr 19, 2024
6 checks passed
@marclaporte
Copy link
Member

Well done @wangxiaoerYah !!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants