Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added CREATE TABLE statements into config/database.php #983

Merged
merged 2 commits into from
Apr 30, 2024

Conversation

PaulTGG
Copy link
Contributor

@PaulTGG PaulTGG commented Apr 29, 2024

Pullrequest

Added CREATE TABLE statement examples into the config/database.php. (The statements are referenced at the start of the file, but they weren't included in the file.)

Issues

  • None

Checklist

  • None

How2Test

  • None

Todo

  • None

Copy link
Member

@Shadow243 Shadow243 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @PaulTGG. By adding it here, we ensure clarity and ease of location for future reference. However, please be mindful to remove the previous instance at: https://github.com/cypht-org/cypht/blob/master/config/app.php#L618 to avoid duplication.

@PaulTGG
Copy link
Contributor Author

PaulTGG commented Apr 30, 2024

Thank you @PaulTGG. By adding it here, we ensure clarity and ease of location for future reference. However, please be mindful to remove the previous instance at: https://github.com/cypht-org/cypht/blob/master/config/app.php#L618 to avoid duplication.

Where is the best place for that info? Should it be in the app.php, or in the database.php? If the former, then I'll close the PR. If the latter, then the line at the top of database.php mentioning the sql statements should be removed.

@Shadow243
Copy link
Member

Thank you @PaulTGG. By adding it here, we ensure clarity and ease of location for future reference. However, please be mindful to remove the previous instance at: https://github.com/cypht-org/cypht/blob/master/config/app.php#L618 to avoid duplication.

Where is the best place for that info? Should it be in the app.php, or in the database.php? If the former, then I'll close the PR. If the latter, then the line at the top of database.php mentioning the sql statements should be removed.

Instinctively, in database.php, especially since there is not too much data there so it is clear and easy to find.

@PaulTGG
Copy link
Contributor Author

PaulTGG commented Apr 30, 2024

@Shadow243 app.php is updated.

@PaulTGG PaulTGG requested a review from Shadow243 April 30, 2024 16:01
Copy link
Member

@Shadow243 Shadow243 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, @PaulTGG. Thanks!

@Shadow243
Copy link
Member

@PaulTGG I don't understand why I see 3 commits instead of 2, did you do a local rebase ?

@PaulTGG
Copy link
Contributor Author

PaulTGG commented Apr 30, 2024

@PaulTGG I don't understand why I see 3 commits instead of 2, did you do a local rebase ?

Yes, there was a non-conflicting commit I added to my fork. (This is my first time contributing to a github project, so I'm still figuring things out... XD)

Added CREATE TABLE statements into the config/database.php.  (The statements are referenced at the top of the file, but they weren't included.)
@Shadow243
Copy link
Member

@PaulTGG I don't understand why I see 3 commits instead of 2, did you do a local rebase ?

Yes, there was a non-conflicting commit I added to my fork. (This is my first time contributing to a github project, so I'm still figuring things out... XD)

Oh it's good now I just removed the other commit and then rebase with git pull --rebase https://github.com/cypht-org/cypht.git master

@Shadow243 Shadow243 merged commit 9ca886e into cypht-org:master Apr 30, 2024
6 checks passed
@Shadow243
Copy link
Member

Since we've merged the changes, we'll need to update the documentation accordingly at: https://www.cypht.org/install-2x.html

Screenshot 2024-04-30 at 19 54 23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants