Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Container does not shut down after test failure in electron #566

Closed
dschulten opened this issue Dec 30, 2021 · 3 comments
Closed

Container does not shut down after test failure in electron #566

dschulten opened this issue Dec 30, 2021 · 3 comments

Comments

@dschulten
Copy link

dschulten commented Dec 30, 2021

cypress/included:9.2.0

When I execute the tests with cypress run (i.e. electron) and some tests fail, the cypress process logs the failure but does not return. The process stays alive until I kill it. Only if the tests succeed, the cypress process returns.

In Concourse this has the unfortunate effect that failing tests never get reported, rather they hang.

Expectation: the cypress container should return an error code for failing tests and shut down.

Note: I have observed the same behaviour with cypress run locally outside of docker in electron.

Workaround: use --browser chrome

@dschulten dschulten changed the title Container does not shut down after test failure Container does not shut down after test failure in electron Dec 31, 2021
@mjhenkes
Copy link
Member

mjhenkes commented Jan 4, 2022

Hey @dschulten, I setup a super simple repo with a failing test that i can run from the docker container, mjhenkes/cypress-test-repo, but i'm unable to recreate your issue.

Is there any more information you can provide about how to recreate the scenario where the container fails to shut down?

@dschulten
Copy link
Author

I'll try to provide a reproducible test.

@MikeMcC399
Copy link
Collaborator

Closing due to inactivity.

@MikeMcC399 MikeMcC399 closed this as not planned Won't fix, can't repro, duplicate, stale May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants