Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Stefano's ReacJSDays workshop on the workshop page #2142

Closed
amirrustam opened this issue Oct 9, 2019 · 3 comments · Fixed by #2145
Closed

Add Stefano's ReacJSDays workshop on the workshop page #2142

amirrustam opened this issue Oct 9, 2019 · 3 comments · Fixed by #2145
Assignees
@amirrustam @bahmutov
Labels
good-first-issue Hacktoberfest

Comments

@amirrustam
Copy link
Contributor

amirrustam commented Oct 9, 2019 •
edited

I'm submitting a...

[ ] Bug report
[X] Content update
[ ] Process update (build, deployment, ... )

Type of bug / changes

Add the following ReachJS Days testing workshop to the workshop page of the docs.

Link: https://noriste.github.io/reactjsday-2019-testing-course
Title: ReactJSDay 2019 Testing Course
Published on Github by Stefano Magni
@amirrustam amirrustam changed the title Add Stefano's ReacJSDays workshop to courses page Add Stefano's ReacJSDays workshop on the workshop page Oct 9, 2019
@bahmutov
Copy link
Contributor

bahmutov commented Oct 9, 2019

it is beautiful workshop site

@Diegoafv
Copy link
Contributor

Diegoafv commented Oct 9, 2019

Can I help with this one?

iepoch added a commit to iepoch/cypress-documentation that referenced this issue Oct 10, 2019
@iepoch
Content Update
78a26ae 
[x] Workshop Content cypress-io#2142
@iepoch iepoch mentioned this issue Oct 10, 2019
Closed
Diegoafv added a commit to Diegoafv/cypress-documentation that referenced this issue Oct 10, 2019
@Diegoafv
ISSUE cypress-io#2142
a57416f
@Diegoafv Diegoafv mentioned this issue Oct 10, 2019
Merged
@amirrustam
Copy link
Contributor Author

@Diegoafv Sure thing, and thank you. Request my review on the PR.

jennifer-shehane added a commit that referenced this issue Oct 15, 2019
@Diegoafv @jennifer-shehane
ISSUE #2142 (#2145)
382eaed 
* ISSUE #2142

* Update workshops to include headings for each workshop

- Add image for Cypress workshop to match ‘workshop’ style
- Removed excess extra images from repo
- Removed image thumbnails of contributors - instead refer to repo for
exact list since this could go out of date.


Co-authored-by: Jennifer Shehane <jennifer@cypress.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amirrustam amirrustam

@bahmutov bahmutov

Labels
good-first-issue Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ISSUE #2142 Diegoafv/cypress-documentation
4 participants
@amirrustam @jennifer-shehane @bahmutov @Diegoafv