Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add examples for how to upload videos for retried tests #3951

Merged
merged 2 commits into from
Jun 2, 2021

Conversation

jennifer-shehane
Copy link
Member

I’ve had people open this issue a few times now, asking for a feature to also upload videos for retried tests:

This is actually already possible, but I don’t think people are finding it since it’s in the ‘after:spec’ API page. Why would anyone look there?

  • This adds the example to the ‘Screenshots & Videos’ page as well as ‘Test Retries’.
  • It also frames the example as ‘upload video on test retries’ instead of ‘delete videos that didn’t pass’, which is less direct on the intent.
  • Question: Is there a way to reuse snippets of the docs? We have this same exact code sample in the docs in 3 places now and I would prefer if it could be edited in one place.

@robertguss
Copy link
Contributor

@jennifer-shehane I am looking into how to create a re-usable markdown component. I think we can leverage this: https://www.npmjs.com/package/@nuxtjs/markdownit

I will submit a PR if I get it things working and keep you posted.

@robertguss
Copy link
Contributor

robertguss commented May 27, 2021

I wasn't able to get that @nuxtjs/markdownit library working. I will see if I can find another way.

@robertguss
Copy link
Contributor

@jennifer-shehane I have created DX-324 issue to try and come up with a solution to reuse code blocks in our docs. The DX team is now aware and this is in our backlog now.

Co-authored-by: Robert Guss <robertguss@pm.me>
@jennifer-shehane
Copy link
Member Author

@robertguss Very cool. We used to have this with the old hexo framework, although it was very flawed. So I know there are a few places it could be used.

@robertguss robertguss merged commit 74299af into master Jun 2, 2021
@robertguss robertguss deleted the upload-retried-tests branch June 2, 2021 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants