Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to the cypress-data-session plugin #4128

Closed
wants to merge 1 commit into from

Conversation

bahmutov
Copy link
Contributor

@cowboy
Copy link
Contributor

cowboy commented Sep 30, 2021

I'm concerned that users may be confused about what this plugin might be used for, since has the name "session" in it, but seems to have nothing to do with sessions.

@cowboy
Copy link
Contributor

cowboy commented Sep 30, 2021

@bahmutov have you considered a name like cypress-persistent-data or cypress-memoize?

@bahmutov
Copy link
Contributor Author

bahmutov commented Sep 30, 2021 via email

@cowboy
Copy link
Contributor

cowboy commented Sep 30, 2021

Nah, the users will be confused anyway, and confusion can be solved by the readme and examples

If it's likely to to confuse users, we're not going to be able to add it here. If you can rename the plugin to something that doesn't have session in the name and better expresses what the plugin is doing, feel free to open a new PR, and we'll re-review.

Thanks!

@cowboy cowboy closed this Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants