Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding info for CYPRESS_VERIFY_TIMEOUT #4271

Merged
merged 2 commits into from
Dec 20, 2021
Merged

Conversation

tbiethman
Copy link
Contributor

New docs are associated with: cypress-io/cypress#18290

@tbiethman tbiethman self-assigned this Dec 14, 2021
@vercel
Copy link

vercel bot commented Dec 14, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/cypress-io/cypress-documentation/3tBXmmHGEjjnqRo5GrqwWg76mK9x
✅ Preview: https://cypress-documentation-git-verify-timeout-env-cypress-io.vercel.app

cypress verify
```

Note that the `cypress verify` command is executed as part of the `cypress open`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this always ran on these commands or only in certain scenarios? I might be helpful to add this note in reverse under the cypress open & cypress run sections to add a link to this section

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tbiethman I think it's only run in certain conditions - like if we can't immediately find it installed? Would have to look at code.

Copy link
Contributor Author

@tbiethman tbiethman Dec 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The timeout only comes into play when the verify smoke test executes. We run the smoke test when:

  • We run the verify command directly with --dev option
    • this bypasses the binary check and forces the smoke test to run
  • We run the run/open/verify commands and the binary has not been previously validated
    • if not previously validated, the smoke test is run as part of the binary validation process.
    • there is logic for a --force option in here to force the validation, but it's no longer supported and errors with unknown option if provided

verify is skipped entirely for run/open when run with the --dev flag.

@tbiethman tbiethman merged commit c13f2e1 into 9.2.0-release Dec 20, 2021
@tbiethman tbiethman deleted the verify-timeout-env branch December 20, 2021 23:12
mjhenkes pushed a commit that referenced this pull request Dec 21, 2021
* Adding readFile/writeFile doc around new timeout features (#4244)

* docs: Add documentation for using child/dual commands in TS (#4263)

Co-authored-by: Chris Breiding <chrisbreiding@gmail.com>

* 9.2.0 changelog.

* add changelog for #18290

* chore: clarify cy.intercept fixture encoding behavior (#4278)

Co-authored-by: Ben Alman <cowboy@rj3.net>

* types in interept command docs

* add chagnelog for #19363

* add changelogs for #19377 & #18549

* typo. Thanks Shawn

* Adding info for CYPRESS_VERIFY_TIMEOUT (#4271)

* Adding info for CYPRESS_VERIFY_TIMEOUT

* Updating docs with other PR content and additional clarification around verify usage

* Update List of Valid Test Configuration Config Values (#4252)

Co-authored-by: Jennifer Shehane <jennifer@cypress.io>
Co-authored-by: Emily Rohrbough <emilyrohrbough@users.noreply.github.com>
Co-authored-by: Emily Rohrbough <emilyrohrbough@yahoo.com>

Co-authored-by: Tyler Biethman <tbiethman@users.noreply.github.com>
Co-authored-by: Den Klimovsky <xumepadismal@users.noreply.github.com>
Co-authored-by: Emily Rohrbough <emilyrohrbough@yahoo.com>
Co-authored-by: Emily Rohrbough <emilyrohrbough@users.noreply.github.com>
Co-authored-by: Ben Alman <cowboy@rj3.net>
Co-authored-by: David Munechika <david@cypress.io>
Co-authored-by: Jennifer Shehane <jennifer@cypress.io>
jordanpowell88 pushed a commit to jordanpowell88/cypress-documentation that referenced this pull request Jan 4, 2022
* Adding readFile/writeFile doc around new timeout features (cypress-io#4244)

* docs: Add documentation for using child/dual commands in TS (cypress-io#4263)

Co-authored-by: Chris Breiding <chrisbreiding@gmail.com>

* 9.2.0 changelog.

* add changelog for #18290

* chore: clarify cy.intercept fixture encoding behavior (cypress-io#4278)

Co-authored-by: Ben Alman <cowboy@rj3.net>

* types in interept command docs

* add chagnelog for #19363

* add changelogs for #19377 & #18549

* typo. Thanks Shawn

* Adding info for CYPRESS_VERIFY_TIMEOUT (cypress-io#4271)

* Adding info for CYPRESS_VERIFY_TIMEOUT

* Updating docs with other PR content and additional clarification around verify usage

* Update List of Valid Test Configuration Config Values (cypress-io#4252)

Co-authored-by: Jennifer Shehane <jennifer@cypress.io>
Co-authored-by: Emily Rohrbough <emilyrohrbough@users.noreply.github.com>
Co-authored-by: Emily Rohrbough <emilyrohrbough@yahoo.com>

Co-authored-by: Tyler Biethman <tbiethman@users.noreply.github.com>
Co-authored-by: Den Klimovsky <xumepadismal@users.noreply.github.com>
Co-authored-by: Emily Rohrbough <emilyrohrbough@yahoo.com>
Co-authored-by: Emily Rohrbough <emilyrohrbough@users.noreply.github.com>
Co-authored-by: Ben Alman <cowboy@rj3.net>
Co-authored-by: David Munechika <david@cypress.io>
Co-authored-by: Jennifer Shehane <jennifer@cypress.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants