Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update clashing types with jest answer #4600

Closed

Conversation

bchen1029
Copy link

@bchen1029 bchen1029 commented Jun 29, 2022

closes #4559
see: cypress-io/cypress#22059 for discussion

@vercel
Copy link

vercel bot commented Jun 29, 2022

@bchen1029 is attempting to deploy a commit to the Cypress Team on Vercel.

A member of the Team first needs to authorize it.

@CLAassistant
Copy link

CLAassistant commented Jun 29, 2022

CLA assistant check
All committers have signed the CLA.

@netlify
Copy link

netlify bot commented Jun 29, 2022

👷 Deploy request for cypress-docs pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 1100f98

@bchen1029
Copy link
Author

Hoping this is a major priority! thx~

Copy link

@maria-kravtsova maria-kravtsova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, please merge this!

@garmeeh
Copy link

garmeeh commented Aug 26, 2022

Hey @bchen1029 I also needed to add cypress to my exclude for it to work.

Not sure if it was something on my end but just in case the docs should reflect it.

{
  "exclude": ["cypress.config.ts", "cypress", "node_modules"]
}

We are using react-scripts@5.0.1

@bchen1029
Copy link
Author

bchen1029 commented Aug 26, 2022

Hey @bchen1029 I also needed to add cypress to my exclude for it to work.

Not sure if it was something on my end but just in case the docs should reflect it.

{
  "exclude": ["cypress.config.ts", "cypress", "node_modules"]
}

We are using react-scripts@5.0.1

@garmeeh really appreciate! just wanna confirm that I also need to add node_modules to exclude right ?

@garmeeh
Copy link

garmeeh commented Aug 30, 2022

@bchen1029 sorry, I missed the notification on your reply. I wasn’t 100% sure on if node_modules should be there but seen some examples with it so added it. I don’t think it is doing any harm being there anyway.

@bchen1029
Copy link
Author

bchen1029 commented Sep 4, 2022

Yes, please merge this!

@maria-kravtsova @elylucas @rockindahizzy
could you help merge this PR if you're free? It might be helpful for cypress users, really appreciate:)

@marktnoonan
Copy link
Contributor

@elylucas I'm not sure how the Vercel authorization step works?

@jennifer-shehane
Copy link
Member

jennifer-shehane commented Oct 3, 2023

I created a new PR to track this since this one is so out of date #5514

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document adding ./cypress.config.ts to tsconfig.exclude to avoid conflicts with Jest
6 participants