Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add dev server function config API #4699

Merged
merged 3 commits into from
Sep 22, 2022

Conversation

lmiller1990
Copy link
Contributor

@vercel
Copy link

vercel bot commented Aug 31, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
cypress-documentation ✅ Ready (Inspect) Visit Preview Sep 22, 2022 at 4:14AM (UTC)

Copy link
Contributor

@astone123 astone123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@lmiller1990
Copy link
Contributor Author

Just waiting on original feature to be review by Brian.

@brian-mann
Copy link
Member

brian-mann commented Sep 21, 2022

From looking at the implementation code it seems like baseConfig is yielded to the async webpackConfig function, but no example demonstrates that.

Nevermind I see your comment here: cypress-io/cypress#23605 (comment)

@lmiller1990 lmiller1990 merged commit 2173300 into master Sep 22, 2022
@lmiller1990 lmiller1990 deleted the add-async-dev-server-config branch September 22, 2022 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants