Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update browser launch options for env key #4723

Closed

Conversation

ryanjduffy
Copy link
Contributor

Docs for new env key added to launchOptions in cypress-io/cypress#23624

@netlify
Copy link

netlify bot commented Sep 10, 2022

👷 Deploy request for cypress-docs pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 5e063f7

@vercel
Copy link

vercel bot commented Sep 10, 2022

@ryanjduffy is attempting to deploy a commit to the Cypress Team on Vercel.

A member of the Team first needs to authorize it.

@CLAassistant
Copy link

CLAassistant commented Sep 10, 2022

CLA assistant check
All committers have signed the CLA.

Co-authored-by: Lachlan Miller <lachlan.miller.1990@outlook.com>
@lmiller1990 lmiller1990 self-requested a review September 12, 2022 00:41
@emilyrohrbough emilyrohrbough changed the base branch from master to release-10.8.0 September 12, 2022 16:13
@lmiller1990
Copy link
Contributor

LGTM

Let's merge once 10.8 is out with the fixes.

@emilyrohrbough emilyrohrbough deleted the branch cypress-io:release-10.8.0 September 13, 2022 18:19
@lmiller1990
Copy link
Contributor

@emilyrohrbough was this supposed to be merged? Accidental close?

@ryanjduffy
Copy link
Contributor Author

Closed automatically when the branch it was targeting was closed. I may have done that a few times accidentally in the past 🙃

@lmiller1990
Copy link
Contributor

So we need to re-open and merge this, I don't have permissions on this repo, maybe @elylucas?

@ryanjduffy
Copy link
Contributor Author

I think we'll have to reopen. afaik, you can't reopen PRs that were closed like this and, strangely, you can retarget it either. I'll open a new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants