Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add component test devserver plugins #5217

Merged
merged 2 commits into from
May 5, 2023
Merged

Conversation

fochlac
Copy link
Contributor

@fochlac fochlac commented Apr 26, 2023

  • add helper that significatly simplifies the dev-server api (cypress-ct-custom-devserver)
  • add esbuild-dev-server plugins (cypress-devserver-esbuild)

 * add helper that significatly simplifies the dev-server api (cypress-ct-custom-devserver)
 * add esbuild-dev-server plugins (cypress-devserver-esbuild)
@netlify
Copy link

netlify bot commented Apr 26, 2023

👷 Deploy request for cypress-docs pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 7be5a45

@warrensplayer warrensplayer requested a review from a team May 4, 2023 18:01
@warrensplayer
Copy link
Contributor

@fochlac

Thanks for submitting the two plugins! The following are the steps we use to determine if we will publish links in our docs. It looks like you have completed these steps, but just wanted you to sign off that you have done this. My only request is if you are able to update the links for the CI badges in the two README files to point to the CI projects and not just the badge image.

  • 🚀 Works with the latest major version of Cypress
  • 🛠 Plugin purpose is clearly documented (in a README or docs website)
  • 📝 Well-written documentation - A great example (link)
  • 🔬 Tested using Cypress - tests using Cypress can act as both example usage and test coverage
  • 👷‍♀️ CI pipeline that's passing (CircleCI and Github Actions are both free for Open Source)

If you have reason to believe your plugin does not need to meet certain requirements, please feel free to provide justification.

@fochlac
Copy link
Contributor Author

fochlac commented May 4, 2023

Hi @warrensplayer,
thanks for the review! I just updated the badges, I actually did not check this and just pasted them above before.
The listed conditions should be fulfilled, I checked the guidelines before opening the PR and made sure everything is covered. :)

@warrensplayer warrensplayer merged commit 75e9f0c into cypress-io:main May 5, 2023
@warrensplayer warrensplayer removed their assignment May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants