Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI Introduction - Official Cypress Docker images #5858

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

MikeMcC399
Copy link
Contributor

@MikeMcC399 MikeMcC399 commented Jul 1, 2024

Issue

The section Continuous Integration > Introduction > Setting up CI > Official Cypress Docker Images includes one outdated example which is supposed to work, but doesn't work anymore. This is followed by an example which is not supposed to work. These are examples for running Cypress Docker images locally, not in CI.

The section does not provide an introduction into using Cypress Docker images in CI.

Comment

The first example is moved to Docker build and run, whilst the second example is moved to Docker interactive, allowing the misplaced examples to be removed from Continuous Integration > Introduction > Setting up CI > Official Cypress Docker Images.

Change

Replace with information about why and how Cypress Docker images can be used in CI, including their publication to

Copy link

netlify bot commented Jul 1, 2024

👷 Deploy request for cypress-docs pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit c24c0b7

@cypress-app-bot
Copy link
Collaborator

@MikeMcC399 MikeMcC399 marked this pull request as ready for review July 1, 2024 09:47
@MikeMcC399

This comment was marked as outdated.

Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Such an improvement. This really speaks to the way our users are actually using the docker images. 👏🏻 👏🏻 👏🏻

@jennifer-shehane jennifer-shehane merged commit 0c1e848 into cypress-io:main Jul 1, 2024
5 checks passed
@MikeMcC399
Copy link
Contributor Author

@jennifer-shehane

Such an improvement. This really speaks to the way our users are actually using the docker images. 👏🏻 👏🏻 👏🏻

Thanks! There are still a few more tweaks necessary to get the Docker information consistent and useful across the board. Stay tuned! 🙂

@MikeMcC399 MikeMcC399 deleted the docker-ci-intro branch July 2, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants