Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure pipeline fails for PRs in fork #612

Closed
MikeMcC399 opened this issue Mar 31, 2023 · 4 comments
Closed

Azure pipeline fails for PRs in fork #612

MikeMcC399 opened this issue Mar 31, 2023 · 4 comments

Comments

@MikeMcC399
Copy link
Contributor

Problem description

The workflow azure-ci.yml fails if triggered by a PR submission from a fork.

Analysis

The record key used in the workflow azure-ci.yml is defined as a secret.

# map the secret Cypress record key as environment variable for this step
CYPRESS_RECORD_KEY: $(CYPRESS_RECORD_KEY)

The project ID is defined in cypress.config.js

'projectId': '4b7344',

Comparison with PR from parent

PRs from the parent repository are checked successfully. For example

PR #607
Job 12412776602

shows successful https://cloud.cypress.io/projects/4b7344/runs/23962

@emilyrohrbough
Copy link
Member

@MikeMcC399 Discussed with the team and we intend to remove running these in Azure and we intend to maintain these example configuration for reference. I'll close once we have updated CI to stop running these.

@MikeMcC399
Copy link
Contributor Author

@emilyrohrbough

Discussed with the team and we intend to remove running these in Azure and we intend to maintain these example configuration for reference. I'll close once we have updated CI to stop running these.

That sounds like a good move! Thank you! I will look forward to be able to submit PRs and see only green ticks ✅ instead of ❌!

@MikeMcC399
Copy link
Contributor Author

The issue is resolved now. For example, PR #608 shows

image

👍🏻

@MikeMcC399
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants