Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add jsdoc pluginsfile #354

Merged
merged 4 commits into from Feb 5, 2020
Merged

Add jsdoc pluginsfile #354

merged 4 commits into from Feb 5, 2020

Conversation

kuceb
Copy link
Contributor

@kuceb kuceb commented Feb 4, 2020

  • add JSDoc to plugins file for type-completions for on(...) events and config
  • lowercase reference types

@claassistantio
Copy link

claassistantio commented Feb 4, 2020 •
edited

CLA assistant check
All committers have signed the CLA.

@chrisbreiding chrisbreiding mentioned this pull request Feb 4, 2020
Merged
5 tasks
bahmutov
bahmutov approved these changes Feb 4, 2020
View reviewed changes
Copy link
Contributor

@bahmutov bahmutov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, checked it locally against new types for plugins, working

@cypress
Copy link

cypress bot commented Feb 4, 2020 •
edited


Test summary

114 • 0 • 0 • 0

Run details
Project cypress-example-kitchensink
Status Passed
Commit 04f40bd
Started Feb 4, 2020 11:01 PM
Ended Feb 4, 2020 11:04 PM
Duration 03:13 💡
OS Linux Ubuntu Linux - 14.04
Browser Electron 78

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@jennifer-shehane jennifer-shehane merged commit 035fa6c into master Feb 5, 2020
@bahmutov
Copy link
Contributor

bahmutov commented Feb 5, 2020

🎉 This PR is included in version 1.9.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@emilyrohrbough emilyrohrbough deleted the add-jsdoc-pluginsfile branch March 30, 2023 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jennifer-shehane jennifer-shehane jennifer-shehane approved these changes

@bahmutov bahmutov bahmutov approved these changes

@chrisbreiding chrisbreiding Awaiting requested review from chrisbreiding

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kuceb @claassistantio @bahmutov @jennifer-shehane