ci: remove testomatio/check-tests workflow #667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
MikeMcC399
force-pushed
the
remove/code-analysis
branch
3 times, most recently
from
634735d
to
1f57ef0
Compare
MikeMcC399
force-pushed
the
remove/code-analysis
branch
from
1f57ef0
to
923c2b5
Compare
MikeMcC399
force-pushed
the
remove/code-analysis
branch
2 times, most recently
from
fb78916
to
519872f
Compare
MikeMcC399
force-pushed
the
remove/code-analysis
branch
2 times, most recently
from
600210a
to
dec0414
Compare
MikeMcC399
force-pushed
the
remove/code-analysis
branch
from
dec0414
to
7ab4ed5
Compare
warrensplayer
approved these changes
Jun 12, 2023
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the workflow .github/workflows/checks.yml.
The workflow relies on the outdated JavaScript action testomatio/check-tests and it may fail starting on
May 18Jun 14, 2023 if no action is taken.Reasons for removal
The workflow produces deprecation warnings concerning
node12(see for example job 4918239075)GitHub Blog announced on May 4, 2023: "Node 12 has been out of support since April 2022, as a result we have started the deprecation process of Node 12 for GitHub Actions. We plan to migrate all actions to run on Node16 by Summer 2023.
Following on from our warning in workflows using Node 12, we will start enforcing the use of Node16 rather than Node12 on the
18th of May14th of June."Issue stable branch gives Node.js 12 deprecation warning testomatio/check-tests#79 was closed without resolution, so there is no JavaScript action offering from testomatio/check-tests which has been tested on Node16 and is using Node16 by default.
Issue
stablebranch not updated since Sep 2021 testomatio/check-tests#98 lists other discrepancies.Alternatives
In the meantime this repository (
cypress-io/cypress-example-kitchensink) is set up for more extensive standard linting witheslint(see .eslintrc) using:Skipped and exclusive tests would now be caught by
mocha/no-skipped-tests(warning) andmocha/no-exclusive-tests(error) respectively when executingnpm run lint.