Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unused/unnecessary deps #777

Merged
merged 3 commits into from
Jan 2, 2024
Merged

Conversation

jennifer-shehane
Copy link
Member

@jennifer-shehane jennifer-shehane commented Dec 29, 2023

Execa isn't used - it's referenced in commented out code in Circle.yml for debugging purposes (I suppose?) Removing the dep so we don't have to keep up with dep and dep updates.

colon-names is just not really a necessary dep. If enforces npm script formatting.

Copy link

netlify bot commented Dec 29, 2023

Deploy Preview for cypress-example-kitchensink ready!

Name Link
🔨 Latest commit 8cd251c
🔍 Latest deploy log https://app.netlify.com/sites/cypress-example-kitchensink/deploys/658f1492258e1e000890289a
😎 Deploy Preview https://deploy-preview-777--cypress-example-kitchensink.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

cypress bot commented Dec 29, 2023

Passing run #27270 ↗︎

0 124 0 0 Flakiness 0

Details:

remove colon-names
Project: cypress-example-kitchensink Commit: 8cd251c32c
Status: Passed Duration: 04:13 💡
Started: Dec 29, 2023 7:01 PM Ended: Dec 29, 2023 7:05 PM

Review all test suite changes for PR #777 ↗︎

@jennifer-shehane jennifer-shehane changed the title chore: remove unused execa dep chore: remove unused/unnecessary deps Dec 29, 2023
Copy link

cypress bot commented Dec 29, 2023

Passing run #27271 ↗︎

0 124 0 0 Flakiness 0

Details:

Merge 8cd251c into 09f370c...
Project: cypress-example-kitchensink Commit: 87a8f78dc4 ℹ️
Status: Passed Duration: 04:48 💡
Started: Dec 29, 2023 7:02 PM Ended: Dec 29, 2023 7:07 PM

Review all test suite changes for PR #777 ↗︎

@jennifer-shehane jennifer-shehane merged commit 6c12b30 into master Jan 2, 2024
45 checks passed
@jennifer-shehane jennifer-shehane deleted the remove-execa branch January 2, 2024 16:52
@cypress-app-bot
Copy link
Collaborator

🎉 This PR is included in version 2.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants