-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update to node 18.16.0 #844
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… linting against files
AtofStryker
changed the title
chore: udpate to node 18.15.0
chore: update to node 18.15.0
Sep 3, 2023
AtofStryker
force-pushed
the
chore/update_to_node_18_15_0
branch
from
September 3, 2023 17:41
7f55a65
to
3adda9c
Compare
…erly load extension into chrome
AtofStryker
force-pushed
the
chore/update_to_node_18_15_0
branch
from
September 3, 2023 17:45
3adda9c
to
60cdde2
Compare
3 tasks
AtofStryker
changed the title
chore: update to node 18.15.0
chore: update to node 18.16.0
Sep 3, 2023
nagash77
previously approved these changes
Sep 5, 2023
AtofStryker
commented
Sep 5, 2023
chrisbreiding
approved these changes
Sep 6, 2023
will wait to merge this in until cypress-io/cypress#27715 is approved and ready to ship |
nagash77
approved these changes
Sep 6, 2023
cacieprins
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updates CER to use node 18.15.0, chrome 114, and firefox 114
Since we are using node 18, we need to update to webpack 5 and react-scripts 5. Linting was run on a few jobs to help start the dev server, as well as
.env
options being updated.the react devtools
--load-extension
needed to be used to work correctly, and the extension has also been updated. This is the large reason for so many files changed