move module outside of TS_NODE_COMPILER process env

cypress-io · Aug 10, 2023 · 0bc6c0a · 0bc6c0a
1 parent 88d8322
commit 0bc6c0a
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/packages/server/lib/plugins/child/ts_node.js b/packages/server/lib/plugins/child/ts_node.js
@@ -22,6 +22,7 @@ const getTsNodeOptions = (tsPath, registeredFile) => {
    * we need to only set options that are supported in this version of TypeScript.
    */
   const compilerOptions = {
+    module: 'commonjs',
     ...(semver.satisfies(version, '>=4.5.0')
       // Only adding this option for TS >= 4.5.0
       ? { preserveValueImports: false }
@@ -35,9 +36,6 @@ const getTsNodeOptions = (tsPath, registeredFile) => {
     try {
       // @ts-ignore - compilerOptions is an object we can assign properties on.
       // It's the 'tsconfig.compilerOptions'.
-      compilerOptions.module = 'commonjs'
-      // @ts-ignore - moduleResolution is an object we can assign properties on.
-      // It's the 'tsconfig.compilerOptions'.
       compilerOptions.moduleResolution = 'node'
       compiler = require.resolve(process.env.TS_NODE_COMPILER, { paths: [path.dirname(registeredFile)] })
     } catch {

diff --git a/packages/server/test/unit/plugins/child/ts_node_spec.js b/packages/server/test/unit/plugins/child/ts_node_spec.js
@@ -22,7 +22,9 @@ describe('lib/plugins/child/ts_node', () => {
         transpileOnly: true,
         compiler: 'typescript/lib/typescript.js',
         dir: '/path/to/plugins',
-        compilerOptions: {},
+        compilerOptions: {
+          module: 'commonjs',
+        },
         ignore: [
           '(?:^|/)node_modules/',
           '/packages/telemetry/dist/span-exporters/ipc-span-exporter',
@@ -41,6 +43,7 @@ describe('lib/plugins/child/ts_node', () => {
         compiler: 'typescript/lib/typescript.js',
         dir: '/path/to/plugins',
         compilerOptions: {
+          module: 'commonjs',
           preserveValueImports: false,
         },
         ignore: [