Skip to content

Commit

Permalink
chore: change path created in prevous PR to make windows compliant
Browse files Browse the repository at this point in the history
empty commit to run ci [run ci]

squash this
  • Loading branch information
AtofStryker committed May 21, 2024
1 parent 27471ad commit 163cf7e
Show file tree
Hide file tree
Showing 4 changed files with 19 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .circleci/workflows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ windowsWorkflowFilters: &windows-workflow-filters
- equal: [ develop, << pipeline.git.branch >> ]
# use the following branch as well to ensure that v8 snapshot cache updates are fully tested
- equal: [ 'update-v8-snapshot-cache-on-develop', << pipeline.git.branch >> ]
- equal: [ 'feat/vite_5_support', << pipeline.git.branch >> ]
- equal: [ 'chore/fix_illegal_characters_in_windows', << pipeline.git.branch >> ]
- matches:
pattern: /^release\/\d+\.\d+\.\d+$/
value: << pipeline.git.branch >>
Expand Down
20 changes: 18 additions & 2 deletions packages/server/test/integration/http_requests_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -3964,8 +3964,24 @@ describe('Routes', () => {
})
})

/**
* NOTE: certain characters cannot be used inside our own monorepo due to our system tests also needing to run
* inside Windows. The following are reserved characters:
*
* < (less than)
* > (greater than)
* : (colon)
* " (double quote)
* / (forward slash)
* \ (backslash)
* | (vertical bar or pipe)
* ? (question mark)
* * (asterisk)
*
* @see https://learn.microsoft.com/en-us/windows/win32/fileio/naming-a-file#naming-conventions for more details
*/
it('can serve files with special characters in the fileServerFolder path', async function () {
await this.setupProject({ fileServerFolder: `dev/_ :;.,"'!(){}[]@<>=-+*$&\`|~^ĵ符` })
await this.setupProject({ fileServerFolder: `dev/_ ;.,'!(){}[]@=-+$&\`~^ĵ符` })

return this.rp({
url: `${this.proxy}/foo.txt`,
Expand All @@ -3975,7 +3991,7 @@ describe('Routes', () => {
})
.then((res) => {
expect(res.statusCode).to.eq(200)
expect(res.headers).to.have.property('x-cypress-file-path', encodeURI(`${Fixtures.projectPath('no-server')}/dev/_ :;.,"'!(){}[]@<>=-+*$&\`|~^ĵ符/foo.txt`))
expect(res.headers).to.have.property('x-cypress-file-path', encodeURI(`${Fixtures.projectPath('no-server')}/dev/_ ;.,'!(){}[]@=-+$&\`~^ĵ符/foo.txt`))
expect(res.body).to.eq('foo')
})
})
Expand Down

0 comments on commit 163cf7e

Please sign in to comment.