push afterSpecTotal instead of afterSpec property

cypress-io · May 9, 2024 · 6fb1a51 · 6fb1a51
1 parent abe9bf6
commit 6fb1a51
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 5 deletions.
diff --git a/packages/server/lib/cloud/api/index.ts b/packages/server/lib/cloud/api/index.ts
@@ -290,7 +290,9 @@ export type ProtocolMetadata = ArtifactMetadata & {
     size: number
     offset: number
   }
-  afterSpecDurations?: AfterSpecDurations
+  afterSpecDurations?: AfterSpecDurations & {
+    afterSpecTotal: number
+  }
 }
 
 export type UpdateInstanceArtifactsPayload = {

diff --git a/packages/server/lib/cloud/artifacts/artifact.ts b/packages/server/lib/cloud/artifacts/artifact.ts
@@ -34,7 +34,9 @@ export interface ArtifactUploadResult {
   allErrors?: Error[]
   uploadDuration?: number
   originalError?: Error
-  afterSpecDurations?: AfterSpecDurations
+  afterSpecDurations?: AfterSpecDurations & {
+    afterSpecTotal: number
+  }
   specAccess?: {
     offset: number
     size: number

diff --git a/packages/server/lib/cloud/protocol.ts b/packages/server/lib/cloud/protocol.ts
@@ -59,7 +59,7 @@ export class ProtocolManager implements ProtocolManagerShape {
   private _runnableId: string | undefined
   private _captureHash: string | undefined
   private _afterSpecDurations: AfterSpecDurations & {
-    afterSpec: number
+    afterSpecTotal: number
   } | undefined
 
   get protocolEnabled (): boolean {
@@ -181,7 +181,7 @@ export class ProtocolManager implements ProtocolManagerShape {
       const durations = await this.invokeAsync('afterSpec', { isEssential: true })
 
       this._afterSpecDurations = durations ? {
-        afterSpec: (performance.now() + performance.timeOrigin) - startTime,
+        afterSpecTotal: (performance.now() + performance.timeOrigin) - startTime,
         ...durations,
       } : undefined
 

diff --git a/system-tests/test/record_spec.js b/system-tests/test/record_spec.js
@@ -2364,7 +2364,7 @@ describe('e2e record', () => {
               },
             })
 
-            expect(artifactReport?.protocol?.afterSpecDurations?.afterSpec).to.be.a('number')
+            expect(artifactReport?.protocol?.afterSpecDurations?.afterSpecTotal).to.be.a('number')
           })
         })
       })