correct return signature of afterSpec; add debug

cypress-io · May 23, 2024 · 8378e9d · 8378e9d
1 parent 96d0519
commit 8378e9d
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/packages/server/lib/cloud/api/index.ts b/packages/server/lib/cloud/api/index.ts
@@ -512,6 +512,8 @@ export default {
   },
 
   updateInstanceArtifacts (options: UpdateInstanceArtifactsOptions, body: UpdateInstanceArtifactsPayload) {
+    debug('PUT %s %O', recordRoutes.instanceArtifacts(options.instanceId), body)
+
     return retryWithBackoff((attemptIndex) => {
       return rp.put({
         url: recordRoutes.instanceArtifacts(options.instanceId),

diff --git a/packages/server/lib/cloud/protocol.ts b/packages/server/lib/cloud/protocol.ts
@@ -178,7 +178,8 @@ export class ProtocolManager implements ProtocolManagerShape {
 
     debug({ startTime })
     try {
-      const durations = await this.invokeAsync('afterSpec', { isEssential: true })
+      const ret = await this.invokeAsync('afterSpec', { isEssential: true })
+      const durations = ret?.durations
 
       const afterSpecTotal = (performance.now() + performance.timeOrigin) - startTime
 
@@ -187,6 +188,8 @@ export class ProtocolManager implements ProtocolManagerShape {
         ...(durations ? durations : {}),
       }
 
+      debug('Persisting after spec durations in state: %O', this._afterSpecDurations)
+
       return undefined
     } catch (e) {
       // rethrow; this is try/catch so we can 'finally' ascertain duration

diff --git a/packages/types/src/protocol.ts b/packages/types/src/protocol.ts
@@ -27,7 +27,7 @@ export interface AppCaptureProtocolCommon {
   beforeTest(test: Record<string, any>): Promise<void>
   preAfterTest(test: Record<string, any>, options: Record<string, any>): Promise<void>
   afterTest(test: Record<string, any>): Promise<void>
-  afterSpec (): Promise<AfterSpecDurations | undefined>
+  afterSpec (): Promise<{ durations: AfterSpecDurations } | undefined>
   connectToBrowser (cdpClient: CDPClient): Promise<void>
   pageLoading (input: any): void
   resetTest (testId: string): void