Skip to content

Commit

Permalink
fix: angular schematic readme update. add check to make sure e2e fold…
Browse files Browse the repository at this point in the history
…er exists to avoid deletion error. (#16506)

* fix: add attribution. add check for e2e folder to fix error that shows when none present.

* doc: update attribution

* doc: remove extra <br /> tag

* doc: add link to plugins discussion

* chore: remove unused sem-ver dependency.
  • Loading branch information
admah committed May 13, 2021
1 parent 0cea625 commit ae33b5c
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 3 deletions.
10 changes: 9 additions & 1 deletion npm/cypress-schematic/README.md
Expand Up @@ -138,6 +138,14 @@ Read our docs to learn more about all the [configuration options](http://on.cypr

Read our docs to learn more about speeding up test execution in CI via [Cypress parallelization](http://on.cypress.io/parallelization)

## Questions or Issues?

Visit our [plugins discussion](https://github.com/cypress-io/cypress/discussions/categories/plugins) to ask questions or report issues.

## License

This project is licensed under an MIT license.
This project is licensed under an MIT license.

## Community Recognition

Inspired by [@briebug/cypress-schematic](https://github.com/briebug/cypress-schematic).
1 change: 0 additions & 1 deletion npm/cypress-schematic/package.json
Expand Up @@ -35,7 +35,6 @@
"chai": "4.2.0",
"cypress": "0.0.0-development",
"mocha": "3.5.3",
"semantic-release": "^17.4.2",
"typescript": "~4.2.4"
},
"license": "MIT",
Expand Down
4 changes: 3 additions & 1 deletion npm/cypress-schematic/src/schematics/cypress/index.ts
Expand Up @@ -129,7 +129,9 @@ function removeFiles (): Rule {
.forEach((projectName) => {
const projectRoot = projects[projectName].root

deleteDirectory(tree, `${projectRoot}/e2e`)
if (tree.exists(`e2e`)) {
deleteDirectory(tree, `${projectRoot}/e2e`)
}
})

return tree.overwrite('./angular.json', JSON.stringify(angularJsonValue, null, 2))
Expand Down

0 comments on commit ae33b5c

Please sign in to comment.