fix: handle race condition with windows and the cri client

cypress-io · Apr 13, 2022 · d74642b · d74642b · cypress-bot · Apr 13, 2022
1 parent 97a1f3c
commit d74642b
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/packages/server/lib/browsers/browser-cri-client.ts b/packages/server/lib/browsers/browser-cri-client.ts
@@ -64,16 +64,14 @@ export class BrowserCriClient {
         const versionInfo = await CRI.Version({ host: HOST, port })
         const browserClient = await create(versionInfo.webSocketDebuggerUrl, onAsynchronousError)
 
-        const browserCriClient = new BrowserCriClient(browserClient, versionInfo, port, onAsynchronousError)
-
         const { targetInfos: targets } = await browserClient.send('Target.getTargets')
 
         if (targets.length === 0) {
-          await browserCriClient.close()
+          await browserClient.close()
           throw new Error('Could not find any targets in browser')
         }
 
-        return browserCriClient
+        return new BrowserCriClient(browserClient, versionInfo, port, onAsynchronousError)
       } catch (err) {
         retryIndex++
         const delay = _getDelayMsForRetry(retryIndex, browserName)